This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjan
previously approved these changes
Dec 20, 2021
mrcnski
commented
Dec 20, 2021
mrcnski
commented
Dec 20, 2021
ro-tex
previously approved these changes
Dec 21, 2021
13 tasks
ro-tex
previously approved these changes
Jan 11, 2022
- [X] Fix makeUrl - [X] Add tests
ro-tex
reviewed
Feb 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the MySky singleton issue, it looks fine. Let's resolve that one and merge this.
…referred-portal-refresh
ro-tex
approved these changes
Feb 14, 2022
peterjan
approved these changes
Feb 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Overview
Note: Has not been tested yet. Waiting for the corresponding MySky changes, then will test on
alpha
MySky.Full flow
Checklist
Review and complete the checklist to ensure that the PR is complete before assigned to an approver.